basic gcs storage adapter no expiry or multipart upload #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnyaug
reviewed
Aug 16, 2020
block/gcs/adapter.go
Outdated
| if err != nil { | ||
| return qualifiedKey, err | ||
| } | ||
| if qualifiedKey.StorageType != block.StorageTypeS3 { |
There was a problem hiding this comment.
Perhaps we can make it "gs://" instead of "s3://" for the storage namespace of the repo, and then replace it here to s3.
This way the functionality will not be changed on the next "increment"
Possible?
There was a problem hiding this comment.
possible - we will have 'gs' be the block adapter name with the configuration in the next iteration
johnnyaug
approved these changes
Aug 16, 2020
nopcoder
added a commit
that referenced
this pull request
Aug 27, 2020
* basic gcs storage adapter no expiry or multipart upload * fix adapter receiver name * code review changes Former-commit-id: bd4255f9154e6d1ea372aa7d3c04a888a71b1d03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #481