Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/list commits with children #458

Merged
merged 10 commits into from
Aug 16, 2020
Merged

Conversation

tzahij
Copy link
Contributor

@tzahij tzahij commented Aug 9, 2020

No description provided.

@tzahij tzahij requested a review from nopcoder August 9, 2020 11:30
Copy link
Contributor

@nopcoder nopcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type of merge_type is catalog_merge_type - the change should be part of the next sql and not the initial one

@arielshaqed arielshaqed changed the title Feature/list commits with sons Feature/list commits with children Aug 13, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #458 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #458      +/-   ##
==========================================
- Coverage   42.08%   42.05%   -0.03%     
==========================================
  Files         119      119              
  Lines       10248    10255       +7     
==========================================
  Hits         4313     4313              
- Misses       5447     5454       +7     
  Partials      488      488              
Impacted Files Coverage Δ
catalog/cataloger_diff.go 45.16% <100.00%> (ø)
catalog/cataloger_list_commits.go 81.13% <100.00%> (+2.87%) ⬆️
catalog/db.go 82.47% <100.00%> (ø)
catalog/views.go 98.73% <100.00%> (ø)
config/logger.go 63.79% <0.00%> (-12.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76aed24...4e335a8. Read the comment docs.

@nopcoder nopcoder merged commit 74b2cf5 into master Aug 16, 2020
@nopcoder nopcoder deleted the feature/list_commits_with_sons branch August 16, 2020 09:53
nopcoder pushed a commit that referenced this pull request Aug 27, 2020
Former-commit-id: 2bd64d333981f54c78f87b86ac5e0a663762fe98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants