Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Node.js language bindings context aware #2841

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

segevfiner
Copy link
Contributor

@segevfiner segevfiner commented Dec 28, 2023

They don't have any dynamic global data, so all it takes is just declaring them as such

Contributed on behalf of Swimm

They don't have any dynamic global data, so all it takes is just declaring them as such
@verhovsky
Copy link
Contributor

We'll have to submit a PR with this change to all 113 of these: https://tree-sitter.github.io/tree-sitter/#parsers

@sogaiu
Copy link
Collaborator

sogaiu commented Dec 28, 2023

Though possibly not all are active, I think there are somewhat more than 113.

@segevfiner
Copy link
Contributor Author

Well if it comes down to it, we can always automate opening those PRs? Not sure how changes to the generation template or grammar generation were handled before. Not merging this and the accompanying PR to node-tree-sitter just means I'll have to fork and maintain patching everything by myself :(

@clason
Copy link
Contributor

clason commented Jan 1, 2024

Though possibly not all are active, I think there are somewhat more than 113.

More like 406. Most active parsers are desperately waiting for a new tree-sitter release to regenerate the grammar (which doesn't regenerate the bindings though).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants