Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During my research into tree-sitter CST traversal, I found out that Node.js tree-sitter binding doesn't contain cached getter
nodeIsMissing
. Because of that, when using TreeCursor, the only way to determine if the SyntaxNode is missing is to call thecursor.currentNode.isMissing()
method. By doing this, traversal performance goes out the window. web-binding for tree-sitter exposesnodeIsMissing
cached field, but Node.js binding doesn't. This PR remedies the situation.Before:
After:
Refs tree-sitter/tree-sitter#1469
Signed-off-by: Vladimir Gorej vladimir.gorej@gmail.com