feat: port to prebuildify #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Electron.js had to be removed from prebuildify. That shouldn't be a problem because 1. Those versions were very old. 2. Few tree-sitter apps seem to be using Electron. It would probably be better to port to node-addon-api anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces prebuild with prebuildify, which is recommended by the prebuild team.
I can't get node-tree-sitter to install on Windows, and I'm hoping this will fix it.
This does remove electron from the list of prebuild targets, but that shouldn't be a problem because:
I recommend looking into the NAPI pull requests so that prebuildify only needs to build a single target.