Add spelling settings #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does not really make sense to spell-check file paths. On the other other hand it does make sense to spell-check the translated messages. Users probably have their editor set up to detect the language of a PO file, so the message strings should be checked while the untranslated message IDs should not. Or maybe they should be, I can add a commit for that too.
Personally I have my Neovim set up where it adds the language of the locale to the default language, i.e. if the global language is English and I am translating a German PO the
spelllangwill be set toen,de. But if a user has only one spelling language he would be getting a lot of false spelling errors if we spell-check the message IDs.You can decide which one makes more sens.