Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add follow_redirect option #66

Merged
merged 2 commits into from
Mar 18, 2021

Conversation

takezoe
Copy link
Member

@takezoe takezoe commented Mar 17, 2021

Purpose

Add follow_redirect option

Overview

client = Presto::Client.new(
  server: "localhost:8880",   # required option
  ssl: {verify: false},
  catalog: "native",
  schema: "default",
  user: "frsyuki",
  password: "********",
  time_zone: "US/Pacific",
  language: "English",
  properties: {
    "hive.force_local_scheduling": true,
    "raptor.reader_stream_buffer_size": "32MB"
  },
  http_proxy: "proxy.example.com:8080",
  http_debug: true,
  follow_redirect: true # add this option
)

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@takezoe takezoe requested a review from a team as a code owner March 17, 2021 16:31
@takezoe takezoe force-pushed the follow-redirect-option branch from bb63110 to a103660 Compare March 17, 2021 17:26
@takezoe takezoe changed the title [WIP] Add follow_redirect option Add follow_redirect option Mar 17, 2021
@takezoe takezoe requested a review from miniway March 17, 2021 17:27
Co-authored-by: NARUSE, Yui <nurse@users.noreply.github.com>
Copy link
Member

@miniway miniway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me

@takezoe takezoe merged commit 9f1b297 into treasure-data:master Mar 18, 2021
@takezoe takezoe deleted the follow-redirect-option branch March 18, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants