Fix for Ruby 3.2.x (#92)

treasure-data · Feb 22, 2023 · 3e8fad5 · 3e8fad5
1 parent 4d8709a
commit 3e8fad5
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/.github/workflows/ruby.yml b/.github/workflows/ruby.yml
@@ -14,9 +14,10 @@ jobs:
   test:
     runs-on: ubuntu-latest
     strategy:
+      fail-fast: false
       matrix:
-        ruby-version: ['2.7', '3.0']
-
+        ruby-version: ['2.7', '3.0', '3.2']
+    timeout-minutes: 5 # Typically ends within 1-2 min
     steps:
       - uses: actions/checkout@v2
       - name: Set up Ruby

diff --git a/lib/trino/client/faraday_client.rb b/lib/trino/client/faraday_client.rb
@@ -70,7 +70,8 @@ def self.faraday_client(options)
     url = "#{ssl ? "https" : "http"}://#{server}"
     proxy = options[:http_proxy] || options[:proxy]  # :proxy is obsoleted
 
-    faraday_options = {url: url, proxy: "#{proxy}"}
+    faraday_options = {url: url}
+    faraday_options[:proxy] = "#{proxy}" if proxy
     faraday_options[:ssl] = ssl if ssl
 
     faraday = Faraday.new(faraday_options) do |faraday|

diff --git a/trino-client.gemspec b/trino-client.gemspec
@@ -27,4 +27,5 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency "addressable", "~> 2.8.1" # 2.5.0 doesn't support Ruby 1.9.3
   gem.add_development_dependency "simplecov", "~> 0.22.0"
   gem.add_development_dependency "standard", "~> 1.24.3"
+  gem.add_development_dependency "psych", "~> 3"
 end