socket_manager_unix: Support REUSEPORT option via envvar #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are there any reasons you decided to use ENV var? ServerEngine usually receives such option as actual argument like https://github.com/treasure-data/serverengine#list-of-all-configurations |
|
By adding option, we need to modify fluentd for new options. |
ganmacs
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We got a balancing issue, incoming data is routed to one worker, from user.
I'm not sure this change fixes the problem, but they want to test REUSEPORT option.
For test, add
SERVERENGINE_USE_SOCKET_REUSEPORTenvvar to enable it.