Create artifact with shaded guava library #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is in the first instance for discussion. There might be better ways of doing this.
What I am trying to do here is to produce an artifact with a shaded guava library. Many clusters provide a terribly old version of guava (15.0). Which is a mess to sort out usually. An easy way around it is to produce a shaded version of it. The maven plugin creates a new artifact "spark-dynamodb-0.0.13-shaded-guava.jar" in which it moves packages so that com.google.common becomes shaded.com.google.common. This allows the jar to be deployed using a new guava version without affecting the rest of the cluster.
It would be cool to have this produced automatically so that I don't need to maintain a fork. I am fairly sure other people would find it useful, too. In my specific use-case I needed it to make it work on AWS Glue, as the DynamicFrame connector was not flexible enough.
Happy to discuss and adapt as needed.