Fix cache bug and fail on cache creation failures #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #296 +/- ##
==========================================
+ Coverage 58.80% 58.92% +0.12%
==========================================
Files 30 30
Lines 954 952 -2
Branches 55 58 +3
==========================================
Hits 561 561
+ Misses 393 391 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit fixes a definite bug. The second removes a warning
printlnI hadn't noticed before. I've changed it to fail hard on any cache creation failure, which seems reasonable to me. If we really want a warning here, we could come up with some other mechanism, but I'd prefer to avoidprintln.