Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collect error metrics #19

Merged
merged 1 commit into from
Mar 3, 2021
Merged

collect error metrics #19

merged 1 commit into from
Mar 3, 2021

Conversation

lixen-wg2
Copy link
Contributor

Makes metrics like incoming_maxlen_exceeded available.

@vkatsuba
Copy link
Contributor

vkatsuba commented Mar 3, 2021 •
edited
Loading

Hi @lixen-wg2,

Many thanks for your contribution! Could you please keep one code style in the module(prometheus_diameter_collector.erl) and use the same size of white spaces?

Regards,
@vkatsuba

@vkatsuba vkatsuba requested a review from RoadRunnr March 3, 2021 16:35
RoadRunnr
RoadRunnr approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@RoadRunnr RoadRunnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please squash the commits into one before merging.

@vkatsuba
Copy link
Contributor

vkatsuba commented Mar 3, 2021

@lixen-wg2 please do squash commits into one commit and then PR will be merged.

@vkatsuba vkatsuba merged commit c029bdd into travelping:master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkatsuba vkatsuba vkatsuba approved these changes

@RoadRunnr RoadRunnr RoadRunnr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lixen-wg2 @vkatsuba @RoadRunnr