Add IMEISV to NASREQ

[javiermtorres]

No description provided.

[RoadRunnr]

why is that a fun? I don't see the need for that.

This could simply be:

OkResponse = {reply, ['AAA' | AAA]},

resulting in a much smaller change.

[javiermtorres]

I wanted to avoid doing all this processing unless it's really necessary, but maybe it's a premature optimization. If you prefer this way, I can change it.

[RoadRunnr]

that code is used in unit test only, I really don't see that that would need optimization.

You could also move the answer construction into the final case when you change it a bit to

    case Msg of
	#{'Calling-Station-Id' := ?MSISDN_FOR_IMEI_SV}
	  when not is_map_key('3GPP-IMEISV') ->
	    {answer_message, 5005};
	_ ->
	    < code for ok response >
    end;

[javiermtorres]

Ok, I'll remove the fun and use the precomputed ok response.

[javiermtorres]

Re: the answer construction, I prefer using explicit conditions for separate cases in tests. The "when not is_map_key" requires that the reader spends time thinking on whether the case they're using complies or not with this condition. This may be ok for the code itself, but makes the life of a tester easier.

[javiermtorres]

The rate limit TC fails due unrelated issues. @RoadRunnr is working on making it more stable.