Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redo of #432 #434

Merged
merged 4 commits into from
Sep 16, 2021
Merged

redo of #432 #434

merged 4 commits into from
Sep 16, 2021

Conversation

RoadRunnr
Copy link
Member

redo of #432

  • split the actual fix and debug logging into seperate commits
  • only collect debug metadata when needed

Currently, a PID is not monitored if it is present in both the contexts
and monitors maps. However, there are cases where a monitor is created
in the monitors list in a register call and then moved to the contexts
list in a bind call, so a new monitor on the same process is created but
not tracked. After a time these monitors fill up the memory and crash the
node.

This commit will not add a new monitor if the PID is present either in
the contexts or the monitors maps.
…r_monitor

Module pgw_s5s8_proxy has debug messages for all related traffic functions.
@RoadRunnr RoadRunnr requested a review from a team as a code owner September 15, 2021 17:18
@RoadRunnr RoadRunnr changed the base branch from master to stable/2.8 September 15, 2021 17:19
Copy link
Contributor

@vkatsuba vkatsuba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If you can, please align code blocks.

@javiermtorres javiermtorres merged commit 4790726 into stable/2.8 Sep 16, 2021
@javiermtorres javiermtorres deleted the fix/gtp-path-mon-as branch September 16, 2021 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants