add PSDBU part or the EPFAR feature #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support `PFCP Session Deleted By the UP function` procedure that is part of the EPFAR (Enhanced PFCP Association Release) feature. The actually release procedure is not supported, but the "Deleted By the UPF" can already be used to signal session deletion in the UPF
vkatsuba
reviewed
Jun 3, 2021
| #report_type{upir = 1} -> | ||
| up_inactivity_timeout; | ||
| _ -> | ||
| deleted_by_upf |
There was a problem hiding this comment.
In erGW-AAA we don't handle/mapping deleted_by_upf termination cause. Do we need also change erGW-AAA? If yes - what number of deleted_by_upf should be mapped?
There was a problem hiding this comment.
- ergw_aaa should use a default mapping for unknown (new) causes. That it doesn't do that is IMHO a bug and should be fixed
- NAS Error would IMHO be a reasonable code
There was a problem hiding this comment.
What number should be for DIAMETER https://tools.ietf.org/html/rfc3588#section-8.15?
There was a problem hiding this comment.
LetMeGoogleThatForYou....
The one assigned by IANA, of course.
The values can also be found in the dictionary: https://github.com/travelping/ergw_aaa/blob/master/dia/diameter_rfc4005_nasreq.dia#L718-L741
fholzhauser
approved these changes
Jun 3, 2021
vkatsuba
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
PFCP Session Deleted By the UP functionprocedure that is partof the EPFAR (Enhanced PFCP Association Release) feature.
The actually release procedure is not supported, but the "Deleted By the UPF"
can already be used to signal session deletion in the UPF