Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added presubmit script distilled from that in trillian #29

Merged
merged 1 commit into from
May 27, 2022

Conversation

mhutchinson
Copy link
Contributor

Removed some of the flags and branches that weren't needed, such as code
generation. This isn't hooked into CI yet, but at least developers can
run ./scripts/presubmit.sh before submitting in the meantime.

Removed some of the flags and branches that weren't needed, such as code
generation. This isn't hooked into CI _yet_, but at least developers can
run `./scripts/presubmit.sh` before submitting in the meantime.
@mhutchinson mhutchinson requested a review from a team as a code owner May 27, 2022 12:20
@mhutchinson mhutchinson requested a review from pav-kv May 27, 2022 12:20
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2022

Codecov Report

Merging #29 (0d36fe9) into main (ff6e921) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #29   +/-   ##
=======================================
  Coverage   88.93%   88.93%           
=======================================
  Files           7        7           
  Lines         497      497           
=======================================
  Hits          442      442           
  Misses         50       50           
  Partials        5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff6e921...0d36fe9. Read the comment docs.

@pav-kv
Copy link
Contributor

pav-kv commented May 27, 2022

Do you reckon this script is github-actionable?

@mhutchinson
Copy link
Contributor Author

mhutchinson commented May 27, 2022

Do you reckon this script is github-actionable?

I'm planning on making it consistent with the other repos, which have GCB run a docker container that performs all of the checks. If we foresee only ever wanting the linter (but we'd need to drop the licence check from presubmit) then maybe we could look at https://github.com/golangci/golangci-lint-action.

@pav-kv
Copy link
Contributor

pav-kv commented May 27, 2022

Consistency across repos is the best thing, SGTM.

I like the simplicity of actions, it worked well for this merkle repo for adding quick easy checks. I don't know if it can fully replace GCB though. Maybe the latter can be used for more involved integration tests.

@mhutchinson mhutchinson merged commit ded06ce into transparency-dev:main May 27, 2022
@mhutchinson mhutchinson deleted the presubmit branch May 27, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants