Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Padronizar comandos da interface CLI com API CKAN #50

Closed
fjuniorr opened this issue Jul 9, 2021 · 0 comments
Closed

Padronizar comandos da interface CLI com API CKAN #50

fjuniorr opened this issue Jul 9, 2021 · 0 comments
Labels
enhancement New feature or request
Milestone
2 iteração

Comments

@fjuniorr
Copy link
Contributor

fjuniorr commented Jul 9, 2021

No description provided.

@fjuniorr fjuniorr added the enhancement New feature or request label Jul 9, 2021
fjuniorr added a commit that referenced this issue Jul 9, 2021
@fjuniorr
Standardize CLI commands with CKAN API
683221f 
Resolves #50
@fjuniorr fjuniorr mentioned this issue Jul 9, 2021
Merged
@fjuniorr fjuniorr added this to the 2 iteração milestone Jul 9, 2021
@fjuniorr fjuniorr closed this as completed Jul 9, 2021
gabrielbdornas added a commit that referenced this issue Jul 9, 2021
@gabrielbdornas
[#38] Correct import create function after #50
a3158b5 
Issue #50 standardized CLI interface commands, that's why we must update its calls inside tests files.
It's not the main objective of #38 but to put tests working again these must be corrected.

Resolves: Chunks of #38 and related to #50
gabrielbdornas added a commit that referenced this issue Jul 9, 2021
@gabrielbdornas
[#38] Remove keyword argument 'temp_dir'
18cd92b 
As shown in #38, click package version 7.1.2 doesn't have 'temp_dir' argument in isolated_filesystem() function.
New click tests documentation: https://click.palletsprojects.com/en/8.0.x/testing/
Old click tests documentation: https://click.palletsprojects.com/en/7.x/testing/
We need to remove this argument and run tests and see the results

This commit also changes the old "public" function to the new "create". As said in commit a3158b5, Issue #50 standardized CLI interface commands, that's why we must update its calls inside tests files.
It's not the main objective of #38 but to put tests working again these must be corrected.

Resolves: Chunks of #38 and related to #50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2 iteração
Development

No branches or pull requests
1 participant
@fjuniorr