Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2° ciclo de iteração pacote dpkgckanmg #15

Closed
27 tasks done
gabrielbdornas opened this issue May 31, 2021 · 1 comment
Closed
27 tasks done

2° ciclo de iteração pacote dpkgckanmg #15

gabrielbdornas opened this issue May 31, 2021 · 1 comment
Milestone

Comments

@gabrielbdornas
Copy link
Contributor

gabrielbdornas commented May 31, 2021

Conforme reunião de alinhamento realizado em 19/01/2021

Prazos

  • Data Início: 20/05/2021
  • Data Fim: 02/06/2021

Responsáveis

  • Desenvolvimento: Gabriel - DTA
  • Revisão e merge: Maurício DTI

Objetivos

Inclua aqui uma breve descrição do objetivo deste ciclo de desenvolvimento, podendo o formato de lista ser utilizado

  • Abertura do repositório

  • Itens restantes da primeira iteração

    • Desenvolvimento de interface CLI para funcionalidades já desenvolvidas
    • Publicar documentação utilizando github pages
  • feature

    • inserir argumento para receber instância CKAN da publicação
      • Função publish;
      • Retirar ambiente padrão homologa (informed_environment='homologa') na função importaDataSet. Padronizar o default na chamada das funções e não nesta função
      • Corrigir Issue Erro ao publicar conjunto de dados em produção #20 sobre erro ao tentar publicar em ambiente de produção
  • Colocar "separador" dentro de cada função, não sendo necessário passá-lo como parametro durante a chamada da função (utilizar os_forward_slash_publish = separador).

    • Função publish;
  • armazenamento único da versão

  • docs

    • escrita da documentação publish cli e web
  • bugfix

    • erro de publicação de conjuntos com múltiplos recursos
    • retirar time.sleep
    • createResource.py não cria novos recursos, recebe argumentos incorretos e duplica datapackage.json
  • refactoring

  • renomear funcões (para inglês)

    • padronizar ordem dos argumento
      • Função publish;
      • Função dataSet;
      • Funçao resource; e
      • Função criarArquivo2.
  • design

Histórico

Dar continuidade aos trabalhos de automatização das rotinas de publicação e manutenção de conjunto de dados no Portal de Dados Abertos de Minas Gerais

Funcionalidades a serem desenvolvidas

  • Projeto Público
  • Documentação online, pública, utilizando-se de ferramentas gratúitas
  • Bug-fix/refatoração
@gabrielbdornas gabrielbdornas added this to the 2 iteração milestone May 31, 2021
gabrielbdornas added a commit that referenced this issue Jun 2, 2021
gabrielbdornas added a commit that referenced this issue Jun 2, 2021
gabrielbdornas added a commit that referenced this issue Jun 2, 2021
…o arquivo setup - dry-package-version-informations
gabrielbdornas added a commit that referenced this issue Jun 2, 2021
…ote para conferir se make continuava funcionando
gabrielbdornas added a commit that referenced this issue Jun 2, 2021
… ao docs/conf e geração da documentação para conferir se make continuava funcionando
gabrielbdornas added a commit that referenced this issue Jun 2, 2021
…de para realizar chamada das funções do pacote
gabrielbdornas added a commit that referenced this issue Jun 4, 2021
gabrielbdornas added a commit that referenced this issue Jun 4, 2021
@fjuniorr
Copy link
Contributor

fjuniorr commented Jun 9, 2021

@gabrielbdornas faltou inserir no escopo dessa iteração a automatização do scan do repositório com o gitleaks para evitar vazamento acidental de chaves do CKAN.

Eu vejo duas opções (com preferência a primeira sem avaliar a complexidade)

  • Configurar um pre-commit hook no git para execução local do gitleaks impedindo commits com segredos
  • Configurar execução do gitleaks via integração continua com o github actions

Mesmo que a gente não faça isso nessa iteração, captura isso por favor.

gabrielbdornas added a commit that referenced this issue Jun 15, 2021
gabrielbdornas added a commit that referenced this issue Jun 15, 2021
@gabrielbdornas gabrielbdornas mentioned this issue Jun 22, 2021
6 tasks
gabrielbdornas added a commit that referenced this issue Jun 28, 2021
gabrielbdornas added a commit that referenced this issue Jun 28, 2021
gabrielbdornas added a commit that referenced this issue Jun 28, 2021
gabrielbdornas added a commit that referenced this issue Jun 28, 2021
gabrielbdornas added a commit that referenced this issue Jun 28, 2021
gabrielbdornas added a commit that referenced this issue Jun 28, 2021
gabrielbdornas added a commit that referenced this issue Jun 28, 2021
gabrielbdornas added a commit that referenced this issue Jul 6, 2021
One of the main objectives of dpckan 2º iteration is the code refactor process.
Because of "readability counts" we're trying to follow the PEP 8 style guide for python code, or the small_snack_case patter in function names and variables' names within loops more explicitly.

Resolves: #15
gabrielbdornas added a commit that referenced this issue Jul 6, 2021
One of the main objectives of dpckan 2º iteration is the code refactor process.
Because of "readability counts" we're trying to follow the PEP 8 style guide for python code, or the small_snack_case patter in function names.

Resolves: #15
fjuniorr added a commit that referenced this issue Jul 6, 2021
fjuniorr added a commit that referenced this issue Jul 6, 2021
The property homepage (frictionless datapackage) was not being mapped to the property url (ckan dataset)

Resolves: #15
gabrielbdornas added a commit that referenced this issue Jul 8, 2021
One of the main objectives of dpckan 2º iteration is the code refactor process.
Because of "readability counts" we're trying to follow the PEP 8 style guide for python code or the small_snack_case patter.
Withdrawing functions that aren't been called in other parts of the code.

Resolves: #15
gabrielbdornas added a commit that referenced this issue Jul 8, 2021
Descriptions inside the dataset's main page and resources' pages weren't been rendered correctly. All pages were showing the dataset's description. Now, the dataset's page is showing the dataset's description together with CKANGELOG.md content file (if it exists), datapackage.json page is showing its resource title and other resources pages are showing resource description.

Resolves: #15, #55
gabrielbdornas added a commit that referenced this issue Jul 8, 2021
Descriptions inside the dataset's main page and resources' pages weren't been rendered correctly. All pages were showing the dataset's description. Now, the dataset's page is showing the dataset's description together with CKANGELOG.md content file (if it exists), datapackage.json page is showing its resource title and other resources pages are showing resource description.

Basically, this is the same description and changes shown in the previous commit (5c2fa2d), but with fill comments inside the code and a correct reference for an issue. This commit doesn't resolve issue 55 as said, instead it solves this one https://github.com/dados-mg/issues/issues/55

Resolves: #15, https://github.com/dados-mg/issues/issues/55
gabrielbdornas added a commit that referenced this issue Jul 8, 2021
After dataset is published user could upload new resources.
This function updates datapackage.json resource and upload new resource and its metadata.

Solves: #15
gabrielbdornas added a commit that referenced this issue Jul 9, 2021
One of the main objectives of dpckan 2º iteration (#15) is the code refactor process.
Because of "readability counts" we're trying to follow the PEP 8 style guide for python code or the small_snack_case patter.
Function lerDadosJsonMapeado no longer exists so its importations in tests files must be removed
Function load_complete_datapackage is imported but needs some tests yet.

Resolves: Chunks of #38
gabrielbdornas added a commit that referenced this issue Jul 9, 2021
One of the main objectives of dpckan 2º iteration (#15) is the code refactor process.
Because of "readability counts" we're trying to follow the PEP 8 style guide for python code or the small_snack_case patter.
Function lerDadosJsonMapeado no longer exists so its importations in tests files must be removed
Function load_complete_datapackage is imported but needs some tests yet.
Part the clean was made in f07668f but this two was forgotten

Resolves: Chunks of #38
gabrielbdornas added a commit that referenced this issue Jul 9, 2021
One of the main objectives of dpckan 2º iteration is the code refactor process.
The original package uses CKAN API library (https://docs.ckan.org/en/2.9/api/#action-api-reference). We've discover that ckanapi library (https://github.com/ckan/ckanapi) is best for the work because It is easier and cleaner than the first library.

Resolves: Chunks of #15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants