@uppy/transloadit: Add option for client name

[Acconut]

This adds an option clientName which, if present, will be appended to the Transloadit-Client header. The idea is that this can be used to add information about which client application created an Assembly. For example, it is helpful to know whether an Assembly was created by the Uppy dashboard on page A or page B.

[github-actions]

Diff output files

diff --git a/packages/@uppy/transloadit/lib/index.js b/packages/@uppy/transloadit/lib/index.js
index e7d9672..a261048 100644
--- a/packages/@uppy/transloadit/lib/index.js
+++ b/packages/@uppy/transloadit/lib/index.js
@@ -417,6 +417,7 @@ export default class Transloadit extends BasePlugin {
       getAssemblyOptions: null,
       limit: 20,
       retryDelays: [7000, 10000, 15000, 20000],
+      clientName: null,
     };
     this.opts = {
       ...defaultOptions,
@@ -545,6 +546,9 @@ function _getClientVersion2() {
   addPluginVersion("OneDrive", "uppy-onedrive");
   addPluginVersion("Zoom", "uppy-zoom");
   addPluginVersion("Url", "uppy-url");
+  if (this.opts.clientName != null) {
+    list.push(this.opts.clientName);
+  }
   return list.join(",");
 }
 function _attachAssemblyMetadata2(file, status) {

[Murderlon]

Is this internal only? If not we need a docs PR too.

[Acconut]

This parameter does not have to be internal-only. Some customers might find it handy to mark the origin of their Assemblies using this option. Should a documentation be done via a PR to https://github.com/transloadit/uppy.io?

[Murderlon]

Should a documentation be done via a PR to https://github.com/transloadit/uppy.io?

Yes please!

[Acconut]

Here you go: transloadit/uppy.io#204

[aduh95]

Shouldn't we add a prefix for consistency?

Suggested change

	list.push(this.opts.clientName)
	list.push(`client-name:${this.opts.clientName}`)

[Acconut]

I am not sure about this. Currently, the format we use is $sdk_name:$sdk_version (or plugin for Uppy). I my mind, the clientName is semantically more similar to $sdk_name than $sdk_version.

That being said, we don't enforce a format right now and people have put other stuff in there as well, so I am unsure how strict we should be here:

[aduh95]

I don't really like the inconsistency, but given the value is empty by default, that's not a big deal. I guess users can still put a colon in the clientName themselves.