remove transpilation of companion #4669
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
why? transpilation adds junk to the source code making it hard to debug issues and stack traces in production because line numbers become messed up also we don't need to transpile because we are targeting relatively recent node versions so stuff like generator-runtime isn't needed anymore example: https://www.unpkg.com/@uppy/companion@4.5.1/lib/server/provider/credentials.js
Merged
aduh95
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
Potentially breaking change because importing @uppy/companion/lib/whatever will no longer work (because the lib/ folder is no more), but probably something we want to do at this point.
If we make a new major for Companion, we should also remove support for Node.js 14.x and 16.x which are EOL as of today.
|
How about Typescript though? If we switch Companion to TS, we'll have lib folder and a compilation step again. |
|
That's a good point, we probably want to do that indeed. |
|
Agreed, ts-fly is fun for Transloadit but not for the world |
|
Closing as #4670 has merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was discussed before but we never got to it:
why? transpilation adds junk to the source code making it hard to debug issues and stack traces in production because line numbers become messed up also we don't need to transpile because we are targeting relatively recent node versions so stuff like generator-runtime isn't needed anymore.
example: https://www.unpkg.com/@uppy/companion@4.5.1/lib/server/provider/credentials.js
alternatively close this PR and instead merge #4670