Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong import for version 7 #4530

Closed

Conversation

shivanshu-tomar
Copy link

Wrong import for version 7 of p-queue

@aduh95
Copy link
Contributor

aduh95 commented Jun 27, 2023

Did you encounter a bug with a specific bundler? p-queue defines an "exports" field in its package.json ensuring the correct file gets loaded when importing. With your change, all the major bundlers (except Parcel and Rollup) now fail to bundle Uppy because ./dist is not listed in the "exports" map of this package, as you can see in the CI.

@Murderlon
Copy link
Member

Discussed with @arturi @aduh95 @mifi, this is not something we can fix. Adding /dist to the import is a hack that will fail other bundlers. If your bundler doesn't support it, or if p-queue incorrectly exports files, it should be fixed there and not downstream.

You can patch for your app though, as we do: https://github.com/transloadit/uppy/pull/4640/files#diff-57a642bb288f1faded77fcf3e5cf8a8771e787a7583072f75e55eca777f8865b

@Murderlon Murderlon closed this Oct 2, 2023
@aduh95 aduh95 mentioned this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants