@uppy/companion: fix 500 when file name contains non-ASCII chars

[aduh95]

For some reason, the AWS SDK doesn't encode those for us and crashes when a metadata contains non-ASCII chars. There was another issue when the key contains non-ASCII char, so now the default key generator now filters those out.

[mifi]

is this also needed with sdk v3 (after #4285 is merged)?

[mifi]

do you get 500 from the AWS servers if you include non-ascii chars, or where does 500 come in?

[aduh95]

is this also needed with sdk v3 (after #4285 is merged)?

Yes

do you get 500 from the AWS servers if you include non-ascii chars, or where does 500 come in?

No, it’s Companion that’s crashing.

[mifi]

so including non-ascii characters in createMultipartUpload MetaData causes companion to crash? like node.js segfault crash? maybe we should report it to aws or node.js

[arturi]

It is 500, but Companion doesn't crash hard after the error, continues to work:

Server:

companion: 2023-06-12T09:34:28.462Z [info] companion.client.version uppy client version @uppy/companion-client=3.1.3
companion: 2023-06-12T09:34:28.888Z [error] 8c00b20a-b1c8-49b5-9e7d-2dca740b6bb8 root.error NetworkingError [NetworkingError]: Invalid character in header content ["x-amz-meta-name"]
    at ClientRequest.setHeader (node:_http_outgoing:647:3)
    at new ClientRequest (node:_http_client:284:14)
    at Object.request (node:https:357:10)
    at features.constructor.handleRequest (/home/uppy/packages/@uppy/companion/node_modules/aws-sdk/lib/http/node.js:45:23)
    at executeSend (/home/uppy/packages/@uppy/companion/node_modules/aws-sdk/lib/event_listeners.js:417:29)
    at Request.SEND (/home/uppy/packages/@uppy/companion/node_modules/aws-sdk/lib/event_listeners.js:431:9)
    at Request.callListeners (/home/uppy/packages/@uppy/companion/node_modules/aws-sdk/lib/sequential_executor.js:102:18)
    at Request.emit (/home/uppy/packages/@uppy/companion/node_modules/aws-sdk/lib/sequential_executor.js:78:10)
    at Request.emit (/home/uppy/packages/@uppy/companion/node_modules/aws-sdk/lib/request.js:686:14)
    at Request.transition (/home/uppy/packages/@uppy/companion/node_modules/aws-sdk/lib/request.js:22:10) {
  code: 'NetworkingError',
  region: 'us-east-1',
  hostname: 'test-test-test.s3.us-east-1.amazonaws.com',
  retryable: true,
  time: 2023-06-12T09:34:28.886Z
}
::ffff:127.0.0.1 - - [12/Jun/2023:09:34:28 +0000] "POST /s3/multipart HTTP/1.1" 500 356 "http://localhost:5173/" "Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/112.0"

Client:

Failed to upload IMG_9078 - 学中文.jpg 

Failed request with status: 500. Internal Server Error message: Invalid character in header content ["x-amz-meta-name"] request-Id: 8c00b20a-b1c8-49b5-9e7d-2dca740b6bb8

[aduh95]

maybe we should report it to […] node.js

No Node.js follows the HTTP/1.1 spec, which says that only ASCII is acceptable in headers.

maybe we should report it to aws

Yeah maybe, I didn't look too far into it but that's beside the point: we have to fix it ASAP for Companion.