Improve logging #3638
Merged
Improve logging #3638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log origin errors with error level
|
e2e tests failed, retrying: https://github.com/transloadit/uppy/runs/5970776595?check_suite_focus=true |
|
@Murderlon seems like another unstable e2e test: I thought we increased the timeout to 60 seconds |
aduh95
reviewed
Apr 11, 2022
private/dev/Dashboard.js
Outdated
Comment on lines
50
to
52
| const companionAllowedHosts = undefined | ||
| // If you want to test dynamic OAuth, instead use: | ||
| // const companionAllowedHosts = Transloadit.COMPANION_PATTERN |
There was a problem hiding this comment.
Can we use import.meta.env.VITE_COMPANION_ALLOWED_HOSTS instead?
There was a problem hiding this comment.
Oh, but then we cannot use the special Transloadit.COMPANION_PATTERN constant, so we would need to duplicate that value inside .env, not sure if that's the best solution?
There was a problem hiding this comment.
Transloadit.COMPANION_PATTERN should work for the vbox as well as prod, so I think it's the only one we're likely to use?
I guess having it en/disable-able from the env would be useful so you can do it in the same place as the VITE_COMPANION_URL.
|
@mifi can we merge this? |
|
yes, after another round of reviews maybe |
aduh95
reviewed
Jul 6, 2022
aduh95
approved these changes
Jul 6, 2022
Merged
github-actions bot
added a commit
that referenced
this pull request
Jul 6, 2022
| Package | Version | Package | Version | | -------------------- | ------- | -------------------- | ------- | | @uppy/companion | 3.7.0 | @uppy/transloadit | 2.3.2 | | @uppy/locales | 2.1.1 | @uppy/robodog | 2.8.2 | | @uppy/provider-views | 2.1.2 | uppy | 2.12.2 | - @uppy/provider-views: improve logging (Mikael Finstad / #3638) - docs: de-dupe companion dev docs (Mikael Finstad / #3852) - @uppy/companion: Getkey safe behavior (Mikael Finstad / #3592) - website: fix broken links (YukeshShr / #3861) - @uppy/companion: doc: fix Google Drive example (Antoine du Hamel / #3855) - @uppy/locales,@uppy/transloadit: Fix undefined error in in onTusError (Merlijn Vos / #3848) - @uppy/companion: build an ARM64 container (Stuart Auld / #3841) - @uppy/locales: Add missing translations and reorder nl_NL locale (Kasper Meinema / #3839) - docs: Fix typo in aws-s3-multipart.md (Ikko Ashimine / #3838) - meta: do not rebase when preparing beta candidates (Antoine du Hamel) - meta: fix hard-coded branch name in release script (Antoine du Hamel)
HeavenFox
pushed a commit
to docsend/uppy
that referenced
this pull request
Jun 27, 2023
| Package | Version | Package | Version | | -------------------- | ------- | -------------------- | ------- | | @uppy/companion | 3.7.0 | @uppy/transloadit | 2.3.2 | | @uppy/locales | 2.1.1 | @uppy/robodog | 2.8.2 | | @uppy/provider-views | 2.1.2 | uppy | 2.12.2 | - @uppy/provider-views: improve logging (Mikael Finstad / transloadit#3638) - docs: de-dupe companion dev docs (Mikael Finstad / transloadit#3852) - @uppy/companion: Getkey safe behavior (Mikael Finstad / transloadit#3592) - website: fix broken links (YukeshShr / transloadit#3861) - @uppy/companion: doc: fix Google Drive example (Antoine du Hamel / transloadit#3855) - @uppy/locales,@uppy/transloadit: Fix undefined error in in onTusError (Merlijn Vos / transloadit#3848) - @uppy/companion: build an ARM64 container (Stuart Auld / transloadit#3841) - @uppy/locales: Add missing translations and reorder nl_NL locale (Kasper Meinema / transloadit#3839) - docs: Fix typo in aws-s3-multipart.md (Ikko Ashimine / transloadit#3838) - meta: do not rebase when preparing beta candidates (Antoine du Hamel) - meta: fix hard-coded branch name in release script (Antoine du Hamel)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was debugging the dynamic oauth I was struggling to understand why the provider auth window was just closing without any feedback. Turns out the errors were being logged at
console.debuglevel, which did not show up the javascript console.This PR will change the logging levels to error, so it's more clear what went wrong. Also added some helper code in developer Dashboard for easier testing of dynamic oauth