Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement facebook app secret proof #5245

Closed
2 tasks done
mifi opened this issue Jun 11, 2024 · 2 comments
Closed
2 tasks done

Implement facebook app secret proof #5245

mifi opened this issue Jun 11, 2024 · 2 comments
Labels

Comments

@mifi
Copy link
Contributor

mifi commented Jun 11, 2024

Initial checklist

  • I understand this is a feature request and questions should be posted in the Community Forum
  • I searched issues and couldn’t find anything (or linked relevant results below)

Problem

Facebook seems to require us to set «require app secret proof» button to be set to ON by june 11 2024. And when that s on, we need to send an app secret proof on every server request to facebook:

https://developers.facebook.com/docs/facebook-login/security/#appsecret

Solution

Implement app secret proof code in companion

Alternatives

Don’t implement anything and pray 🙏

@mifi mifi added the Feature label Jun 11, 2024
@lakesare
Copy link
Contributor

lakesare commented Jun 11, 2024

Thanks for creating this issue! I will add a few comments to clarify our situation.

Facebook makes it sound like app secret proof is optional in their docs, however, as we can see from the email they sent us, app secret proof is mandatory for any app that wants to go into production mode:

image

So, in order to make uppy.io work,
AND, in general, to make any app that uses Uppy + Facebook in production work,
we will need to implement app secret proof support in Uppy.

mifi added a commit that referenced this issue Jun 12, 2024
closes #5245

note that I couldn't get `appsecret_time` working, but it seems to be working without
@aduh95
Copy link
Contributor

aduh95 commented Jul 2, 2024

Fixed by #5249

@aduh95 aduh95 closed this as completed Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants