-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue when trying to load uppy with importmap while running an adblocker #4446
Comments
This behaviour can be easily observed by:
|
That seems unfortunate, but I'm not sure there's much we can do (besides renaming the file maybe). Did you try to report that to uBlock Origin? That seems a false positive on their end. |
I don't think we can report it to uBlock as their whole tactic is speculative blocking. Renaming would be the best option. We did the same for tus: tus/tus-js-client#429 |
@bolinkd are you willing to make a PR? |
@Murderlon I made a PR which was a global find and replace. I'm not sure how to test this locally with Rails importmaps, unfortunately |
Initial checklist
Link to runnable example
No response
Steps to reproduce
We have users who have reported being unable to upload files and we have narrowed it down to adblockers blocking the "EventTracker.js" file that importmap is trying to load
Expected behavior
I would expect Uppy to load without being blocked by adblockers, I believe the issue is with the naming of the EventTracker file and the default rules in ublock (The adblocker that initially caused the issue for us) is blocking the network request because of the suspicious name.
Actual behavior
The file is blocked by the adblocker
The text was updated successfully, but these errors were encountered: