Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set ttl for redis keys created for each upload #3748

Closed
mifi opened this issue May 17, 2022 · 0 comments · Fixed by #3771
Closed

Set ttl for redis keys created for each upload #3748

mifi opened this issue May 17, 2022 · 0 comments · Fixed by #3771
Labels
Bug Companion The auth server (for Instagram, GDrive, etc) and upload proxy (for S3)

Comments

@mifi
Copy link
Contributor

mifi commented May 17, 2022

Keys companion:uuid Are created in redis whenever an upload is started, however not being cleaned up leaking redis space.
@mifi mifi added Bug Companion The auth server (for Instagram, GDrive, etc) and upload proxy (for S3) Triage labels May 17, 2022
mifi added a commit that referenced this issue May 23, 2022
@mifi
expire redis keys after 1 day
bb178ed 
to prevent buildup in redis
fixes #3748
@mifi mifi mentioned this issue May 23, 2022
Merged
mifi added a commit that referenced this issue May 26, 2022
@mifi @tim-kos
expire redis keys after 1 day (#3771)
5bd5d38 
* expire redis keys after 1 day

to prevent buildup in redis
fixes #3748

* reuse redis config logic

* Update packages/@uppy/companion/src/server/Uploader.js

Co-authored-by: Tim Koschuetzki <tim-kos@users.noreply.github.com>

Co-authored-by: Tim Koschuetzki <tim-kos@users.noreply.github.com>
HeavenFox pushed a commit to docsend/uppy that referenced this issue Jun 27, 2023
@mifi @tim-kos
expire redis keys after 1 day (transloadit#3771)
3387b84 
* expire redis keys after 1 day

to prevent buildup in redis
fixes transloadit#3748

* reuse redis config logic

* Update packages/@uppy/companion/src/server/Uploader.js

Co-authored-by: Tim Koschuetzki <tim-kos@users.noreply.github.com>

Co-authored-by: Tim Koschuetzki <tim-kos@users.noreply.github.com>
@subha1206 subha1206 mentioned this issue Aug 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Companion The auth server (for Instagram, GDrive, etc) and upload proxy (for S3)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

expire redis keys after 1 day transloadit/uppy
1 participant
@mifi