Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Google Picker plugins to examples #293

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Add new Google Picker plugins to examples #293

merged 4 commits into from
Dec 18, 2024

Conversation

mifi
Copy link
Contributor

@mifi mifi commented Dec 18, 2024

No description provided.

@Murderlon
Copy link
Member

I think you need to yarn install them first

@mifi
Copy link
Contributor Author

mifi commented Dec 18, 2024

oops good catch, will do. i just edited this in the github editor

@Murderlon Murderlon changed the title add pickers to example Add new Google Picker plugins to examples Dec 18, 2024
@Murderlon
Copy link
Member

i just edited this in the github editor

Have you tested locally this works as expected?

@mifi
Copy link
Contributor Author

mifi commented Dec 18, 2024

yes but i didn't test the actual flow because of allowed origins, I just saw that the oauth window popped up with the allowed origins error

@mifi
Copy link
Contributor Author

mifi commented Dec 18, 2024

let me test with my own key instead

@mifi
Copy link
Contributor Author

mifi commented Dec 18, 2024

For Google photos it works. For drive I'm getting The API developer key is invalid. but it could be due to http://localhost

@Murderlon
Copy link
Member

but it could be due to http://localhost

if they both have it in their allow list in the Google app, it should behave the same? Do you expect it will work suddenly when live? Or better to try something first before merging?

@mifi
Copy link
Contributor Author

mifi commented Dec 18, 2024

i had incorrectly copy-pasted the api key locally, works now

@mifi mifi added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit 3ad1495 Dec 18, 2024
2 checks passed
@mifi mifi deleted the pickers branch December 18, 2024 10:07
Murderlon added a commit that referenced this pull request Jan 8, 2025
* main:
  Remix docs (#288)
  add facebook for real (#301)
  enable facebook (#300)
  Fix "Edit this page" link (#299)
  deps: update uppy to 4.9.0 (#297)
  Add @uppy/webdav docs (#296)
  fix docs for picker (#295)
  fix app id (#294)
  Add new Google Picker plugins to examples (#293)
  Also disable Instagram/Google Drive on the homepage
  Disable Instagram/Facebook on examples for now
  add dynamic year and range (#292)
  deps: update uppy to 4.8.0 (#291)
  update doc (#280)
  Improve companionAllowedHosts doc (#290)
  Document @uppy/google-photos-picker and @uppy/google-drive-picker (#281)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants