-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uppy.io/examples - stop css from affecting uppy #266
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is the correct solution. It should not be possible to override the CSS of Uppy with simple selectors like .main h1
. We should build protections into Uppy to prevent this, either with specificity and uppy-reset
class as we've been doing or the more ambitious undertaking of using cascade layers.
We can merge this as a quickfix, but it will just make us blind the problems other users are still facing.
There are 2 solutions in this pr:
No need for a quickfix merge, I'll revert the "uppy.io/examples - make font alright too" commit in favor of making Uppy more robust against outside css. |
I don't think we should treat uppy.io page as our testing ground for "what css issues users might be having". If we think it's important then we should add h1/etc. styles to So, I think the default behaviour when editing out uppy.io css should be to use high-specificity selectors, e.g. classes, like standardized in this pr (h1 is an exception, because outside framework is bringing that in for us - and because it is indeed good for Uppy to defend against that). |
Fixes transloadit/uppy#4439
Makes headings normal-sized & fixes heading font issues
Before
After
Removes double shadow
Before
After
Increases right-margin for checkboxes
Before
After
In general, in CSS, changes:
all tag references (e.g.
h1
),to unique class references (e.g.
.h1_src-pages-examples-module
).Hopefully that makes the "Uppy CSS is broken on examples page" issue appear less frequently.