Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Google Photos to example #259

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Add Google Photos to example #259

merged 4 commits into from
Jul 11, 2024

Conversation

Murderlon
Copy link
Member

No description provided.

@Murderlon Murderlon requested review from mifi and aduh95 July 10, 2024 11:37
@Murderlon Murderlon self-assigned this Jul 10, 2024
@Murderlon Murderlon marked this pull request as ready for review July 10, 2024 11:37
aduh95
aduh95 reviewed Jul 11, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
aduh95
aduh95 reviewed Jul 11, 2024
View reviewed changes
yarn.lock Outdated Show resolved Hide resolved
@Murderlon @aduh95
Apply suggestions from code review
72d4a18 
Co-authored-by: Antoine du Hamel <antoine@transloadit.com>
@aduh95
Copy link
Contributor

aduh95 commented Jul 11, 2024

Getting this.plugin.uppy.validateAggregateRestrictions is not a function when trying to use the plugin with yarn dev

@Murderlon
Copy link
Member Author

Works on my machine

@aduh95 aduh95 added this pull request to the merge queue Jul 11, 2024
Merged via the queue into main with commit 9a1ee3f Jul 11, 2024
2 checks passed
@aduh95 aduh95 deleted the google-photos branch July 11, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@mifi mifi Awaiting requested review from mifi

Assignees

@Murderlon Murderlon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Murderlon @aduh95