Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaling on rotation blog post #182

Merged
merged 14 commits into from
Nov 30, 2023
Merged

Scaling on rotation blog post #182

merged 14 commits into from
Nov 30, 2023

Conversation

lakesare
Copy link
Contributor

No description provided.

@arturi arturi self-requested a review October 27, 2023 13:24
@lakesare lakesare requested a review from Missing-Tech October 30, 2023 09:57
Copy link
Member

@Missing-Tech Missing-Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pushed my iteration, lgtm! 👍

Copy link
Contributor Author

@lakesare lakesare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you look over these please & incorporate them as you see fit?

blog/2023-10-25-image-editor.md Outdated Show resolved Hide resolved
blog/2023-10-25-image-editor.md Show resolved Hide resolved
blog/2023-10-25-image-editor.md Outdated Show resolved Hide resolved
blog/2023-10-25-image-editor.md Outdated Show resolved Hide resolved
blog/2023-10-25-image-editor.md Outdated Show resolved Hide resolved
blog/2023-10-25-image-editor.md Outdated Show resolved Hide resolved
blog/2023-10-25-image-editor.md Outdated Show resolved Hide resolved
blog/2023-10-25-image-editor.md Outdated Show resolved Hide resolved
@lakesare lakesare requested a review from Missing-Tech November 3, 2023 09:05
@Missing-Tech
Copy link
Member

Just pushed another iteration, addressing most of your comments :) Let me know if there's anything you think needs changing and I'd be happy to take another swing at this until we get it perfect

@lakesare
Copy link
Contributor Author

lakesare commented Nov 8, 2023

@Missing-Tech, would you be able to take it from here, wrap up the blog post & fix the linters & get it merged?

@Missing-Tech
Copy link
Member

Sure I'd love to!

@Missing-Tech
Copy link
Member

Sorry for the delay here! Just fixed some linting errors and it should be merged soon :)

@Missing-Tech Missing-Tech added this pull request to the merge queue Nov 19, 2023
@Missing-Tech Missing-Tech removed this pull request from the merge queue due to a manual request Nov 19, 2023
@Missing-Tech
Copy link
Member

@arturi Is this ok to be merged?

@Missing-Tech Missing-Tech added this pull request to the merge queue Nov 30, 2023
Merged via the queue into main with commit b720464 Nov 30, 2023
@Missing-Tech Missing-Tech deleted the lakesare/rotation branch November 30, 2023 10:48
Murderlon added a commit that referenced this pull request Nov 30, 2023
* main:
  Scaling on rotation blog post (#182)
  deps: update uppy to 3.20.0 (#190)
  Workaround setup-node Yarn bug (#189)
  Fix broken link
  meta: upgrade to Yarn 4 (#188)
  Upgrade to Docusaurus V3 (#184)
  Companion: document new arguments for s3.bucket and s3.getKey (#183)
  Document S3 endpoint for Companion (#179)
  deps: update uppy to 3.18.1 (#180)
  Add "Custom stores" guides (#172)
  deps: update uppy to 3.18.0 (#177)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants