Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement option to start translate full page and show the original text by press Custom Shortcut keys #266

Closed
ggpoll opened this issue Apr 7, 2023 · 9 comments · Fixed by #274
Labels
enhancement New feature or request
Milestone

Comments

@ggpoll
Copy link

ggpoll commented Apr 7, 2023

No description provided.

@vitonsky
Copy link
Collaborator

vitonsky commented Apr 7, 2023

Explain your feature request. You want to hotkey to translate page or to show original text?

@vitonsky vitonsky added the RFC Need to triage label Apr 7, 2023
@ggpoll
Copy link
Author

ggpoll commented Apr 7, 2023

Yes,
Keyboard shortcuts
Switch between the translated and the original page

@vitonsky vitonsky added enhancement New feature or request and removed RFC Need to triage labels Apr 7, 2023
@vitonsky vitonsky added this to the Release 4.1 milestone Apr 7, 2023
@ggpoll
Copy link
Author

ggpoll commented Apr 8, 2023

@vitonsky
Is it possible to release an updated version of 4.1 in advance?
I like your browser extension very much, it works very well
At the same time, it is very urgent to enhance the enhancement I proposed

@vitonsky
Copy link
Collaborator

vitonsky commented Apr 8, 2023

@ggpoll yes, it possible if you will implement this feature. Feel free to open pull request

@ggpoll
Copy link
Author

ggpoll commented Apr 8, 2023

Sorry, my expression is wrong, I have no technical ability, I hope you will implement this feature, I am willing to donate for your work, thank you 😀

@vitonsky
Copy link
Collaborator

vitonsky commented Apr 8, 2023

@ggpoll i understood you, i'm work on offline translation feature now, but your feature request looks useful, i will implement it as soon as possible.

If you want to donate to Linguist, you can find details here: https://github.com/translate-tools/linguist#donations
I can focus on your feature request if it such important for you that you will pay for it, i appreciate voting by money

Thank you for a feedback

@Dook1
Copy link

Dook1 commented Apr 9, 2023

I support this proposal.

@ggpoll
Copy link
Author

ggpoll commented Apr 13, 2023

Thank you very much for your hard work, it is very presumptuous to add a question,
It is whether it is possible to add a menu translation button for the right mouse button at the same time - like the one in the picture
image

@vitonsky
Copy link
Collaborator

@ggpoll this feature been implemented in #83 and will appear in next release soon (next week). Stay tune

vitonsky added a commit that referenced this issue Apr 13, 2023
vitonsky added a commit that referenced this issue Apr 13, 2023
vitonsky added a commit that referenced this issue Apr 13, 2023
vitonsky added a commit that referenced this issue Apr 13, 2023
vitonsky added a commit that referenced this issue Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants