Issues controller update fix

app/controllers/api/v1/issues_controller.rb

@@ -46,13 +46,17 @@ def show
   end
 
   def update
-    # TODO: allow for deletion of individual EntityWithIssues
     issue_params_copy = issue_params
     entities_with_issues_params = issue_params_copy.delete(:entities_with_issues).try(:compact)
     @issue.update!(issue_params_copy)
-    entities_with_issues_params.each do |ewi|
-      ewi_params[:entity] = OnestopId.find!(ewi_params.delete(:onestop_id))
-      @issue.entities_with_issues << EntityWithIssues.find_or_initialize_by(ewi_params)
+    # allowing addition and deletion of EntityWithIssues
+    # An Issue's entities_with_issues will be completely replaced by update request, if specified
+    unless entities_with_issues_params.nil?
+      @issue.entities_with_issues.each { |ewi| @issue.entities_with_issues.delete(ewi) }
+      entities_with_issues_params.each do |ewi|
+        ewi[:entity] = OnestopId.find!(ewi.delete(:onestop_id))
+        @issue.entities_with_issues << EntityWithIssues.create(ewi)
+      end
     end
     render json: @issue
   end
@@ -83,11 +87,6 @@ def create
 
   private
 
-  def set_entity_with_issues_params(ewi_params)
-    ewi_params[:entity] = OnestopId.find!(ewi_params.delete(:onestop_id))
-    @issue.entities_with_issues << EntityWithIssues.find_or_initialize_by(ewi_params)
-  end
-
   def set_issue
     @issue = Issue.find(params[:id])
   end

spec/controllers/api/v1/issue_controller_spec.rb

@@ -107,6 +107,29 @@
       post :update, id: 1, issue: issue
       expect(Issue.find(1).details).to eq "This is a test of updating"
     end
+
+    it 'avoids deleting EntitiesWithIssues when param not supplied' do
+      issue = {
+        "details": "This is a test of updating"
+      }
+      post :update, id: 1, issue: issue
+      expect(Issue.find(1).entities_with_issues.size).to eq 3
+    end
+
+    it 'creates specified EntitiesWithIssues and deletes existing EntitiesWithIssues' do
+      issue = {
+        "details": "This is a test of updating",
+        entities_with_issues: [
+          {
+            "onestop_id": 's-9qscwx8n60-nyecountyairportdemo',
+            "entity_attribute": 'geometry'
+          }
+        ]
+      }
+      post :update, id: 1, issue: issue
+      expect(Issue.find(1).entities_with_issues.size).to eq 1
+      expect(Issue.find(1).entities_with_issues[0].entity.onestop_id).to eq 's-9qscwx8n60-nyecountyairportdemo'
+    end
   end
 
   context 'POST destroy' do