API updates for Dispatcher #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed in the same request this is how the Dispatcher Ember app will do it
…rimary key it already uses email address
# Conflicts: # app/services/gtfs_graph.rb # app/workers/feed_eater_worker.rb
# Conflicts: # spec/controllers/api/v1/changesets_controller_spec.rb
and add in more query parameter filters that will be useful to Dispatcher front-end
using `bundle exec rake annotate`
using `bundle exec rake erd_diagrams`
drewda
added a commit
to transitland/dispatcher
that referenced
this pull request
Feb 23, 2016
described at http://emberjs.com/api/data/classes/DS.RESTAdapter.html#property_coalesceFindRequests depends on additions to Datastore: transitland/transitland-datastore#443
This will make it easier for Ember (and other front-end apps) to filter based on various query parameters. They'll no longer need to know the Onestop ID of a Feed or the SHA1 of a FeedVersion to construct a URL.
drewda
force-pushed
the
api-updates-for-dispatcher
branch
from
3a4c1f8
to
4bc514c
Compare
…ransitland-datastore into api-updates-for-dispatcher
# Conflicts: # README.md # app/controllers/api/v1/feed_versions_controller.rb # config/routes.rb # spec/controllers/api/v1/feed_versions_controller_spec.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API improvements to support Dispatcher additions transitland/dispatcher#26
along with internal refactoring to standardize the way we handle query parameters across API endpoints/controllers.