Enable sourcemaps in rollup config by default #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
| @@ -111,6 +112,21 @@ Here is a [branch](https://github.com/transitive-bullshit/react-modern-library-b | |||
|
|
|||
| Here is a [branch](https://github.com/transitive-bullshit/react-modern-library-boilerplate/tree/feature/material-ui) which demonstrates how to create a module that makes use of a relatively complicated peer dependency, [material-ui](https://github.com/mui-org/material-ui). It shows the power of [rollup-plugin-peer-deps-external](https://www.npmjs.com/package/rollup-plugin-peer-deps-external) which makes it a breeze to create reusable modules that include complicated material-ui subcomponents without having them bundled as a part of your module. | |||
|
|
|||
| ## Sourcemaps | |||
There was a problem hiding this comment.
I'm fine with adding sourcemap generation by default, but I'd rather not add a whole section to the readme devoted to them. imho, the walkthrough instructions are already verbose enough.
transitive-bullshit
requested changes
Feb 27, 2018
raycohen
force-pushed
the
build-sourcemap
branch
from
e31fd5f to
fcc8eb8
Compare
|
I've removed the README changes. I think my only concern is warning people that CRA currently won't pick the sourcemaps up. |
|
Agreed; maybe as a compromise we can add a smaller note in the README with a link to an issue that explains the sourcemap status in-depth? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a followup,
source-map-explorercould be added as suggested inhttps://github.com/facebook/create-react-app/tree/next/packages/react-scripts/template#analyzing-the-bundle-size
Here's the PR that would allow CRA to support using the sourcemaps this PR generates: facebook/create-react-app#2355
It was closed as stale due to lack of interest. Perhaps we can drum up some interest!