Increase randomness of server_id to avoid conflicts

transferwise · May 9, 2024 · 117b796 · 117b796
1 parent 572e08a
commit 117b796
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/tap_mysql/sync_strategies/binlog.py b/tap_mysql/sync_strategies/binlog.py
@@ -809,7 +809,7 @@ def create_binlog_stream_reader(
         server_id = int(config.get('server_id'))
         LOGGER.info("Using provided server_id=%s", server_id)
     else:
-        server_id = random.randint(1, 2 ^ 32)  # generate random server id for this slave
+        server_id = random.randint(1, 2 ** 32 - 1)  # generate random server id for this slave
         LOGGER.info("Using randomly generated server_id=%s", server_id)
 
     engine = config['engine']