Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAIN-B 21655 alternative AK/HI duty location names #14212

Merged
merged 5 commits into from
Nov 15, 2024

Conversation

MInthavongsay
Copy link
Contributor

B-21655

INT PR

Summary

This PR addresses an issue related to searching AK and HI duty locations using common alternative names. It corrects initial migration introduced in B-21481. During migration some of the alternative names were erroneously migrated as official locations into the duty_locations table. This PR corrects it by deleting the records from the duty_locations table and moving it to the duty_location_name table. Each record in the duty_location_names will then be mapped to the official duty location.

this article explains more about the approach used.

Verification Steps for the Author

These are to be checked by the author.

  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

How to test

Edit .envrc and set FEATURE_FLAG_ENABLE_ALASKA=true

  1. Login as customer and setup a move. Search for duty location. Use attached files for reference. Everything highlighted in column A represents a record that is to be in the duty_location_names table. Each new record in duty_location_names table will then be mapped to the official duty locations via foreign key. This mapping is represented in column B next to the official duty location in column A.
    AK-duty-locations-1730773768958 -Reviewed.xlsx
    HI-duty-locations-1730773801336 Reviewed.xlsx
  2. Search using any of the highlighted texts in spreadsheet. Verify returned results contain the official duty location.
    For example:
    Searching for "Stevens Vlg" should return a list containing "Stevens Village, AK 99774".
    Searching for "JBPHH" should return a list containing "JB Pearl Harbor Hickam, HI 96853 " and "JB Pearl Harbor Hickam, HI 96860".

Frontend

  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
  • There are no new console errors in the browser devtools.
  • There are no new console errors in the test output.
  • If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
  • This change meets the standards for Section 508 compliance.

Backend

Database

Any new migrations/schema changes:

  • Follows our guidelines for Zero-Downtime Deploys.
  • Have been communicated to #g-database.
  • Secure migrations have been tested following the instructions in our docs.

Copy link
Contributor

@r-mettler r-mettler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as INT

@r-mettler r-mettler merged commit e4982c9 into main Nov 15, 2024
41 checks passed
@r-mettler r-mettler deleted the B-21655-Alternative-AK_HI-Duty-Location-Names branch November 15, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants