MAIN-B 21655 alternative AK/HI duty location names #14212
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
B-21655
INT PR
Summary
This PR addresses an issue related to searching AK and HI duty locations using common alternative names. It corrects initial migration introduced in B-21481. During migration some of the alternative names were erroneously migrated as official locations into the duty_locations table. This PR corrects it by deleting the records from the duty_locations table and moving it to the duty_location_name table. Each record in the duty_location_names will then be mapped to the official duty location.
this article explains more about the approach used.
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code
How to test
Edit .envrc and set FEATURE_FLAG_ENABLE_ALASKA=true
AK-duty-locations-1730773768958 -Reviewed.xlsx
HI-duty-locations-1730773801336 Reviewed.xlsx
For example:
Searching for "Stevens Vlg" should return a list containing "Stevens Village, AK 99774".
Searching for "JBPHH" should return a list containing "JB Pearl Harbor Hickam, HI 96853 " and "JB Pearl Harbor Hickam, HI 96860".
Frontend
officeApp
class or custommin-width
styling is used to hide any states the would not be visible to the user.Backend
Database
Any new migrations/schema changes: