B 20441 #13539
Merged
B 20441 #13539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
CoryKleinjanCACI
requested review from
MInthavongsay,
antgmann,
r-mettler and
ajlusk
r-mettler
approved these changes
Sep 18, 2024
migrations/app/schema/20240909194514_pricing_unpriced_ms_cs_service_items.up.sql
Show resolved
Hide resolved
MInthavongsay
approved these changes
Sep 18, 2024
begrohmann
reviewed
Sep 18, 2024
migrations/app/schema/20240822180409_adding_locked_price_cents_service_param.up.sql
Show resolved
Hide resolved
begrohmann
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
B-20441
Int Review
Int Review #2
Int Review #3
Summary
When creating a payment request the 'LockedPriceCents' field is now used to determine the price of the MS and CS payment service items.
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code
How to test
NOTE: At this point I would recommend editing the db directly and altering the lockedPriceCents column in mto_service_items to a different value. This way you can validate that the value from this column is the one being used, and not the one from re_task_order_fees (which was used previously and will likely be an identical value in your local to lockedPriceCents, but has the ability to change in prod. Hence this task to lock the pricing down)
Can use the following queries to easily find the service item for MS/CS fee to change the locked price.
select moves.id from moves where moves.locator ='INSERT_MOVE_CODE_HERE';
For MS use msi.re_service_id ='1130e612-94eb-49a7-973d-72f33685e551'
For CS use msi.re_service_id ='9dc919da-9b66-407b-9f17-05c0f03fcb50'
select * from mto_service_items msi where msi.move_id = 'YOUR_ID_FROM_PREV_QUERY' and msi.re_service_id ='1130e612-94eb-49a7-973d-72f33685e551';
Frontend
officeAppclass or custommin-widthstyling is used to hide any states the would not be visible to the user.Backend
Database
Any new migrations/schema changes:
Screenshots