B 20744 int Fix error when Customer doesn't select SIT Expected

[r-mettler]

B-20744

Summary

This fixes a bug when the Customer selects No to SIT Expected question during PPM shipment creation but then a storage type moving expense is later created. The bug is when the Service Counselor attempts to view and submit the approval for the Storage type moving expense on the Review Documents page.

To resolve this we know that since a moving expense of Storage was submitted that SIT was indeed selected so we set the SIT Expected value to true.

Verification Steps for the Author

These are to be checked by the author.

• Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
• Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

• Has the branch been pulled in and checked out?
• Have the BL acceptance criteria been met for this change?
• Was the CircleCI build successful?
• Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

• Instructions for starting storybook
• Instructions for starting the MilMove application
• Instructions for running tests

How to test

1. As a Customer create a new PPM shipment
2. When asked make sure you select SIT Expected to No
3. Submit the shipment
4. Login as a Service Counselor and fix the Orders section and submit the move
5. Login as the Customer again and click Upload PPM Documents
6. Fill out the first and second pages
7. On the third page under Expenses at the bottom and add a new Expense
8. Make sure the expense is STORAGE type
9. Fill out fields
10. Click Save
11. Click Save on the next page
12. Submit your documents
13. Login as the SC again, go to the PPM Closeout Queue and select your shipment
14. Click the Review Documents button
15. Click Accept on the first document and click Continue
16. Verify there aren't any "Something went wrong" error messages like in this screenshot
    
17. Make sure all fields are filled out and click Accept and Continue
18. Make sure you don't see any errors

Frontend

• There are no aXe warnings for UI.
• This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
• There are no new console errors in the browser devtools.
• There are no new console errors in the test output.
• If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
• This change meets the standards for Section 508 compliance.

Backend

• Code follows the guidelines for Logging.
• The requirements listed in Querying the Database Safely have been satisfied.

[antgmann]

Elegant solution and the testing steps worked. I've already merged this into 20740 to minimize conflicts.

[MInthavongsay]

Nitpicking. We might want to add a little comment why we are setting it true "since a moving expense of Storage was submitted that SIT was indeed selected so we set the SIT Expected value to true." It might not be obvious because this handler is a GET and not PATCH ..etc..

[r-mettler]

added comments to both files as to why we are setting sitExpected to true