Skip to content

Commit

Permalink
Ensure distribution archive has execute permissions for files
Browse files Browse the repository at this point in the history
Adjust the zip creation during gradle target distZip,
to include execute file permissions for archived files.
So that the archive can be unpacked and directly used,
on Unix platforms.

Fixes: spotbugs#2540
  • Loading branch information
Simeon Andreev authored and trancexpress committed Aug 30, 2023
1 parent ffa1248 commit 3688fd4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ Currently the versioning policy of this project follows [Semantic Versioning v2.
- Updated the MS_EXPOSE_REP description to mention mutable objects, not just arrays ([#1669](https://github.com/spotbugs/spotbugs/issues/1669))
- Described Configuration option frc.suspicious for bug RC_REF_COMPARISON in bug description ([#2297](https://github.com/spotbugs/spotbugs/issues/2297))
- Fixed FindHEMismatch not reporting HE_SIGNATURE_DECLARES_HASHING_OF_UNHASHABLE_CLASS for some classes ([#2402](https://github.com/spotbugs/spotbugs/issues/2402))
- Added execute file permission to files in the distribution zip ([#2540](https://github.com/spotbugs/spotbugs/issues/2540))

### Added
- New simple name-based AnnotationMatcher for exclude files (now bug annotations store the class java annotations in an attribute called `classAnnotationNames`). For example, use like <Match><Annotation name="org.immutables.value.Generated" /></Match> in an excludeFilter.xml to ignore classes generated by the Immutable framework. This ignores all class, method or field bugs in classes with that annotation.
Expand Down
1 change: 1 addition & 0 deletions spotbugs/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,7 @@ tasks.named('distTar', Tar) {
}
def distZip = tasks.named('distZip', Zip) {
duplicatesStrategy = DuplicatesStrategy.FAIL
fileMode 0755
}
tasks.named('jar') {
dependsOn tasks.named('updateManifest')
Expand Down

0 comments on commit 3688fd4

Please sign in to comment.