Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace rust-yaml #289

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Replace rust-yaml #289

merged 3 commits into from
Apr 9, 2024

Conversation

hasezoey
Copy link
Contributor

@hasezoey hasezoey commented Apr 8, 2024

This PR replaces the crate rust-yaml with serde_yaml as rust-yaml did not have any updates for 3 years since writing and also the maintainer seems to not be contact-able (chyh1990/yaml-rust#160).
Though serde_yaml has also been archived (and deprecated) about 2 weeks ago (at time of writing), we now use a serde struct and could transition over to a different format (like json) easily, or wait until another serde yaml parser comes out (maybe serde_yml will be trusted?).
At least for now serde_yaml will continue to work.

In additon this PR also cleans-up the usize casting for ColorTermusic.

Also now all the themes in /lib/themes/ will be tested to actually be load-able when running cargo test.

PS: the struct Alacritty could be replaced with the new Theme, though that would require a config transition, which is out-of-scope for this PR.

@tramhao tramhao merged commit 069506d into tramhao:master Apr 9, 2024
0 of 4 checks passed
@hasezoey hasezoey deleted the rustyaml branch April 9, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants