Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up a few miscellaneous things #1666

Merged
merged 3 commits into from
Apr 16, 2020
Merged

Clean up a few miscellaneous things #1666

merged 3 commits into from
Apr 16, 2020

Conversation

bradlarsen
Copy link
Contributor

No description provided.

@ehennenfent
Copy link
Contributor

It's fine with me if you want to run isort once against the whole wasm directory. I'm also eventually fine with doing it on the entirety of manticore, but I'd rather hold off on it for now because it could cause merge conflicts for a lot of open PRs.

@bradlarsen
Copy link
Contributor Author

The changes here are extracted from a big branch of many fixes I had that I have been splitting up so it's easier to review.

I realize now that the WASM import sorting commit is unused for later changes in this pull request. Would you like me to get rid of it then?

@ehennenfent ehennenfent merged commit c8a6fc8 into master Apr 16, 2020
@ehennenfent ehennenfent deleted the misc-cleanup branch April 16, 2020 17:15
ekilmer added a commit that referenced this pull request Apr 23, 2020
* master: (28 commits)
  Rework syscall invocation for proper behavior under typeguard (#1672)
  printable_bytes (#1671)
  Fix several incorrect type hints (#1668)
  Add type hints to several parts of Manticore (#1667)
  Fix type confusion in manual CPU tests; delete dead testing code (#1669)
  Rework WASM Imports and Fix Typos (#1666)
  Work on "Model is not Available" errors in tests (#1659)
  Fix TypeGuard Errors in WASM Module (#1601)
  Remove unused arg ans separate output from workspace (#1651)
  Add a badge to README.md for LGTM (#1647)
  Fix 2 problems in Linux `sys_open` support & add type hints (#1657)
  Fix LGTM Errors (#1656)
  Delay WASM Branch Condition Concretization (#1641)
  Add feature for SymbolicSocket through sys_accept (#1618)
  Add a bunch of type hints & fix a few issues with Linux platform emulation (#1645)
  Bump to CheckoutV2 (#1654)
  Add support for `sys_arm_fadvise64_64` (#1648)
  Add __slots__ to expressions (#1635)
  Swap remaining uses of `Z3Solver()` to use the singleton interface (#1649)
  CI: have pytest report 100 slowest tests (#1646)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants