-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use mypy
to check the tests
dir; fix some typing errors
#1610
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! 💯
Speculating from the CI output, but it looks like Also, I've consolidated the |
Previously, the use of The test failure, in this case, was actually due to me incorrectly fixing this bad format string the first time around:
Thanks! |
* master: (23 commits) Update make_VMTests.py (#1628) Update manticore.py (#1627) Symbolic function strategies. (#1609) Fix for returndatasize (#1612) Improve balance related exploration (#1615) Add __format__ to Account (#1613) Use `mypy` to check the `tests` dir; fix some typing errors (#1610) Add a native example program & test case for #1604 (#1606) Hotfix: add long_description_content_type Manticore 0.3.3 (#1598) Improve WASM Memory Ergonomics (#1589) Make sure std files are not None before assigning peer (#1604) Add Examples badge to CI Badges (#1603) Better iterative optimization for expressions (#1599) Fix Regression(s) (#1577) Add missing `python3-dev` dep to quickstart instructions (#1600) Add license to setup.py (#1597) Streamline State Serialization Interface (#1596) Simplify ci.yml (#1588) Fix gas check (#1587) ...
Fixes #1608.
Additionally, this includes a few type annotations in a couple other places, which I added as I was looking there.