Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AArch64: do not use the 'procs' argument #1439

Merged

Conversation

nkaretnikov
Copy link
Contributor

@nkaretnikov nkaretnikov commented May 17, 2019

This change is Reviewable

@nkaretnikov
Copy link
Contributor Author

nkaretnikov commented May 17, 2019

Making sure that both examples still work. (This PR fixes one of them. The other one works fine as is.)

root@5cc4557fdbcd:/manticore# printf "\x00+++" | PYTHONPATH=. ./examples/script/aarch64/basic.py
2019-05-17 17:13:42,578: [72448] m.p.platform:WARNING: Unimplemented system call at 0x43901c: sys_faccessat(0xffffffffffffff9c, 0x470d28, 0x0)
hook else
(declare-fun STDIN () (Array (_ BitVec 32) (_ BitVec 8)))
(declare-fun a_1 () (_ BitVec 8))(assert (= a_1 (select STDIN #x00000003)))
(declare-fun a_2 () (_ BitVec 8))(assert (= a_2 (select STDIN #x00000002)))
(declare-fun a_3 () (_ BitVec 8))(assert (= a_3 (select STDIN #x00000001)))
(declare-fun a_4 () (_ BitVec 32))(assert (= a_4 (concat a_1 a_2 a_3 #x00)))
(declare-fun a_5 () (_ BitVec 64))(assert (= a_5 ((_ sign_extend 32) a_4)))
hook if
<BitVecConcat at 7f12b606f5c0>
b'\x00\x00\x00\x00'
hook puts
Message: It is less than or equal to 0x41

root@5cc4557fdbcd:/manticore# PYTHONPATH="." ./examples/script/aarch64/hello42.py | egrep "puts|exit"
puts argument: hello
puts result: 6
exit status: 42

@nkaretnikov nkaretnikov changed the title aarch64: do not use the 'procs' argument AArch64: do not use the 'procs' argument May 17, 2019
Copy link
Contributor

@ehennenfent ehennenfent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ehennenfent ehennenfent merged commit 91bb222 into trailofbits:master May 17, 2019
ekilmer added a commit that referenced this pull request May 30, 2019
* master:
  Restore old init hook behavior (#1447)
  Fix invalid pip argument (#1445)
  Blacken Manticore (#1438)
  Relegate coverage file to plugin (#1442)
  x86: movhps support (#1444)
  Delete statically generated tests (#1443)
  Hardcode expected matching concrete registers (#1437)
  Symbolic tests rf otf (#1441)
  Unicorn dependency update (#1440)
  aarch64: do not use the 'procs' argument (#1439)
  Symbolic tests rf (#1431)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants