Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow OnDemand to be toggled later #1557

Merged
merged 1 commit into from
Sep 6, 2019
Merged

Allow OnDemand to be toggled later #1557

merged 1 commit into from
Sep 6, 2019

Conversation

jackivanov
Copy link
Collaborator

@jackivanov jackivanov commented Aug 21, 2019

Description

This fix allows apple devices to toggle on the OnDemand mode, even if neither WiFi nor Cellular options were chosen during the initial deployment.

The only rule appears to be needed:

<key>OnDemandEnabled</key>
<integer>0</integer>
<key>OnDemandRules</key>
<array>
  <dict>
    <key>Action</key>
    <string>Connect</string>
  </dict>
</array>

Motivation and Context

Fixes #778

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • All new and existing tests passed.

@jackivanov jackivanov merged commit c6f45ea into master Sep 6, 2019
@jackivanov jackivanov deleted the fix/778 branch September 6, 2019 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not having OnDemandEnabled=Y does not allow for "Connect on Demand" to be toggled later
1 participant