PKI to tmpfs #1496
Merged
PKI to tmpfs #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackivanov
force-pushed
the
feature/tmpfs
branch
from
c1223cc to
d4661a1
Compare
disconnect3d
reviewed
Jul 4, 2019
disconnect3d
approved these changes
Jul 8, 2019
iBringit
added a commit
to iBringit/algo
that referenced
this pull request
Nov 4, 2020
This reverts commit 090a60d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed in #145. The config files will be stored in tmpfs only if the
store_pki(retain the PKI) is not chosen, and unmounted once the server is ready. MacOS implementation might be a bit dirty, but I didn't find any other way, so we need to review whether this would be appropriate for merging.Motivation and Context
Closes #145
How Has This Been Tested?
Deployed a few times without errors
Types of changes
Checklist: