Simplify Apple Profile Configuration Template #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will be reviewed after #976 |
|
|
@jackivanov This is ready for review |
|
Doesn't adding extra spaces in the template cause unnecessary spaces to be left in the generated file? |
faf0
force-pushed
the
faf0/apple-profile-template
branch
3 times, most recently
from
cf680f1 to
d55a1da
Compare
|
@davidemyers You are right. I updated this PR to remove unnecessary spaces. |
|
I'm pretty sure it breaks indentation and line breaks now, although it doesn't make it unusable, but makes it unreadable. Probably you can use lstrip_blocks |
|
@jackivanov Your assessment is correct. I enabled lstrip_blocks. |
|
@faf0 Could you, please, rebase from the master? We are going to merge this in 1.1 |
faf0
force-pushed
the
faf0/apple-profile-template
branch
from
7bdfdfc to
fa9d197
Compare
|
@jackivanov rebased from master |
|
Thanks! |
TC1977
pushed a commit
to TC1977/algo
that referenced
this pull request
Mar 26, 2019
* Simplify Apple Profile Configuration Template * enable lstrip_blocks * remove ldashes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix indentation of template statements, remove empty else-clauses, and remove blank newlines.