Skip to content

Commit

Permalink
test_simple: fix accidentally skipped test
Browse files Browse the repository at this point in the history
See pypi#15716 (review)

Signed-off-by: William Woodruff <william@trailofbits.com>
  • Loading branch information
woodruffw committed Sep 23, 2024
1 parent 5e05c1e commit 6a9271d
Showing 1 changed file with 25 additions and 12 deletions.
37 changes: 25 additions & 12 deletions tests/unit/api/test_simple.py
Original file line number Diff line number Diff line change
Expand Up @@ -460,27 +460,40 @@ def test_with_files_with_version_multi_digit(
if renderer_override is not None:
assert db_request.override_renderer == renderer_override


def _update_context(context, content_type, renderer_override):
if renderer_override != "json" or content_type in [
simple.MIME_TEXT_HTML,
simple.MIME_PYPI_SIMPLE_V1_HTML,
]:
return _valid_simple_detail_context(context)
return context

def test_with_files_quarantined_omitted_from_index(self, db_request):
db_request.accept = "text/html"
@pytest.mark.parametrize(
("content_type", "renderer_override"),
CONTENT_TYPE_PARAMS,
)
def test_with_files_quarantined_omitted_from_index(
self, db_request, content_type, renderer_override
):
db_request.accept = content_type
project = ProjectFactory.create(lifecycle_status="quarantine-enter")
releases = ReleaseFactory.create_batch(3, project=project)
_ = [
FileFactory.create(release=r, filename=f"{project.name}-{r.version}.tar.gz")
for r in releases
]

assert simple.simple_detail(project, db_request) == {
context = {
"meta": {"_last-serial": 0, "api-version": API_VERSION},
"name": project.normalized_name,
"files": [],
"versions": [],
"alternate-locations": [],
}
context = _update_context(context, content_type, renderer_override)

assert simple.simple_detail(project, db_request) == context

if renderer_override is not None:
assert db_request.override_renderer == renderer_override


def _update_context(context, content_type, renderer_override):
if renderer_override != "json" or content_type in [
simple.MIME_TEXT_HTML,
simple.MIME_PYPI_SIMPLE_V1_HTML,
]:
return _valid_simple_detail_context(context)
return context

0 comments on commit 6a9271d

Please sign in to comment.