feat(theme): adds the cart template and its corresponding files #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 31, 2021 15:22
…a theme gets generated ISSUES CLOSED: trafilea#53
ISSUES CLOSED: trafilea#53
ISSUES CLOSED: trafilea#53
Nx Cloud ReportCI ran the following commands for commit f344281. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
|
Thank you @jibinycricket! |
sebastiandg7
approved these changes
Jun 1, 2021
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the cart template/js/scss/test files when a theme is generated
ISSUES CLOSED: #53
Current Behavior
After running the
nx generate @trafilea/nx-shopify:theme <theme-name>command, the cart template directory, which is part of the default shopify templates is missing. Without it the cart page returns a 404Expected Behavior
After running the
nx generate @trafilea/nx-shopify:theme <theme-name>command, thesrc/theme/templates/cartshould also be generated along withRelated Issue(s)
#53 - Generated Theme is missing default cart template