fix(build): remove not working media queries splitting

trafilea · Mar 30, 2021 · 72351e1 · 72351e1
1 parent 49eb36b
commit 72351e1
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 29 deletions.
diff --git a/packages/nx-shopify/src/executors/build/schema.d.ts b/packages/nx-shopify/src/executors/build/schema.d.ts
@@ -18,7 +18,6 @@ export interface BuildExecutorSchema {
   main: string;
   tsConfig: string;
   postcssConfig: string;
-  mediaQueriesConfig: string;
   themekitConfig: string;
 
   watch?: boolean;

diff --git a/packages/nx-shopify/src/executors/build/schema.json b/packages/nx-shopify/src/executors/build/schema.json
@@ -25,10 +25,6 @@
       "type": "string",
       "description": "The path to the PostCSS configuration file"
     },
-    "mediaQueriesConfig": {
-      "type": "string",
-      "description": "The path to the media-queries configuration file"
-    },
     "watch": {
       "type": "boolean",
       "description": "Run build when files change",
@@ -88,7 +84,8 @@
     },
     "memoryLimit": {
       "type": "number",
-      "description": "Memory limit for type checking service process in MB. (defaults to 2048)"
+      "description": "Memory limit for type checking service process in MB.",
+      "default": 2048
     },
     "fileReplacements": {
       "description": "Replace files with other files in the build.",

diff --git a/packages/nx-shopify/src/generators/theme/theme.generator.ts b/packages/nx-shopify/src/generators/theme/theme.generator.ts
@@ -85,10 +85,6 @@ function addBuildTarget(
     main: joinPathFragments(sourceRoot, `main.ts`),
     tsConfig: joinPathFragments(projectRoot, `tsconfig.app.json`),
     postcssConfig: joinPathFragments(projectRoot, `postcss.config.js`),
-    mediaQueriesConfig: joinPathFragments(
-      projectRoot,
-      `media-queries.config.js`
-    ),
     themekitConfig: joinPathFragments(projectRoot, `config.yml`),
     sourceMap: true,
     assets: [joinPathFragments(projectRoot, `src/assets`)],

diff --git a/packages/nx-shopify/src/utils/normalize-utils.ts b/packages/nx-shopify/src/utils/normalize-utils.ts
@@ -1,4 +1,3 @@
-
 import { normalizePath } from '@nrwl/devkit';
 import { statSync } from 'fs';
 import { basename, dirname, resolve } from 'path';
@@ -79,7 +78,6 @@ export function normalizeBuildOptions<T extends BuildExecutorSchema>(
     sourceRoot: sourceRoot,
     outputPath: resolve(root, options.outputPath),
     tsConfig: resolve(root, options.tsConfig),
-    mediaQueriesConfig: resolve(root, options.mediaQueriesConfig),
     fileReplacements: normalizeFileReplacements(root, options.fileReplacements),
     assets: options.assets
       ? normalizeAssets(options.assets, root, sourceRoot)

diff --git a/packages/nx-shopify/src/webpack/configs/partials/styles.config.ts b/packages/nx-shopify/src/webpack/configs/partials/styles.config.ts
@@ -1,26 +1,9 @@
-import * as MediaQuerySplittingPlugin from 'media-query-splitting-plugin';
 import * as MiniCssExtractPlugin from 'mini-css-extract-plugin';
 import { Configuration, Plugin } from 'webpack';
 import { BuildExecutorSchema } from '../../../executors/build/schema';
 
 function getExtraPlugins(options: BuildExecutorSchema) {
   const extraPlugins: Plugin[] = [];
-
-  const { mediaQueriesConfig } = options;
-
-  if (mediaQueriesConfig) {
-    const mediaQueries = require(mediaQueriesConfig);
-
-    if (typeof mediaQueries === 'object' && mediaQueries !== null) {
-      extraPlugins
-        .push
-        // new MediaQuerySplittingPlugin({
-        //   media: mediaQueries,
-        //   minify: true,
-        // })
-        ();
-    }
-  }
   return extraPlugins;
 }