Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Host header in HTTP provider request #11237

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Set Host header in HTTP provider request #11237

merged 2 commits into from
Oct 29, 2024

Conversation

nikonhub
Copy link
Contributor

What does this PR do?

This PR allows to set Host header to http providers.

providers:
  http:
    endpoint: "http://localhost:4000/config"
    headers:
      Host: "some.custom.domain"

Motivation

Resolves #11210

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@nikonhub nikonhub mentioned this pull request Oct 28, 2024
Closed
2 tasks
@kevinpollet kevinpollet changed the title Fix host header in go request Set Host header in HTTP provider request Oct 29, 2024
@kevinpollet kevinpollet added this to the next milestone Oct 29, 2024
@kevinpollet
Copy link
Member

Hello @nikonhub,

Can you please add some tests?

@nikonhub
Copy link
Contributor Author

Hello @kevinpollet ,

Just added a test. Let me know if anything is missing.

kevinpollet
kevinpollet approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

rtribotte
rtribotte approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@traefiker traefiker merged commit e8ff825 into traefik:master Oct 29, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtribotte rtribotte rtribotte approved these changes

@kevinpollet kevinpollet kevinpollet approved these changes

Assignees
No one assigned
Labels
area/provider/http kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

Cannot override Host header when using http provider
4 participants
@nikonhub @kevinpollet @rtribotte @traefiker